Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix save action on empty card #243

Merged
merged 4 commits into from
Jun 22, 2024
Merged

[Bug] Fix save action on empty card #243

merged 4 commits into from
Jun 22, 2024

Conversation

mdsaban
Copy link
Contributor

@mdsaban mdsaban commented Jun 20, 2024

What?

  • Fixes save action on empty card. Currently if user clicks on save button, then it creates empty card
  • Improves UI a little bit of the editor card

Screenshot

image

MohamedBassem
MohamedBassem requested changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@MohamedBassem MohamedBassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pressing cmd+Enter still submits an empty card. Let's maybe ignore the submit action if the text is empty as well?

apps/web/components/dashboard/bookmarks/EditorCard.tsx Outdated Show resolved Hide resolved
apps/web/components/dashboard/bookmarks/EditorCard.tsx Outdated Show resolved Hide resolved
apps/web/components/dashboard/bookmarks/EditorCard.tsx Outdated Show resolved Hide resolved
apps/web/components/dashboard/bookmarks/EditorCard.tsx Show resolved Hide resolved
MohamedBassem
MohamedBassem approved these changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@MohamedBassem MohamedBassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments!

@MohamedBassem MohamedBassem merged commit ccfff6b into hoarder-app:main Jun 22, 2024
3 checks passed
@mdsaban mdsaban deleted the fix-save-action branch June 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedBassem MohamedBassem MohamedBassem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdsaban @MohamedBassem